search

ruby-i18n / i18n

Internationalization (i18n) library for Ruby
MIT License
977 stars 408 forks source link

Feature test for issue #606 and disable the optimization if the bug is present #618

Closed casperisfine closed 2 years ago

casperisfine commented 2 years ago

Fix: https://github.com/ruby-i18n/i18n/issues/606

Apologies for the delay, I was somehow convinced I already submitted this...

Note that the fix for the root cause was merged https://github.com/msgpack/msgpack-ruby/pull/246, and it seems like there wasn't that many people impacted, so I'm personally not convinced the workaround is worth it, but of course it's your call.

If you want to ship a workaround, that's how I'd do it.

@radar

cc @paarthmadan

paarthmadan commented 2 years ago

My two-cents:

I agree that the feature testing isn't worth it. It would appear the number of clients affected isn't worth bloating the logic required for performing the feature test.

radar commented 2 years ago

@paarthmadan I agree here. It's likely a (future) bundle update msgpack will make the issue go away. Once the next msgpack version comes out, I feel like this issue will be permanently resolved.

Thank you, and @casperisfine for your working through this issue. I appreciate the assist!