Updating DEFAULT_APPROXIMATIONS with capitalised German Eszett character for consistency

ruby-i18n / i18n

Internationalization (i18n) library for Ruby

MIT License

977 stars 408 forks source link

Updating DEFAULT_APPROXIMATIONS with capitalised German Eszett character for consistency #627

Closed lucapericlp closed 1 year ago

lucapericlp commented 2 years ago

The uppercase equivalent of the German Eszett was released in a much later version of Unicode and isn't included as part of the first 190 diacritics of unicode between 0xC0 & 0x17E so I thought I'd raise this PR in case consistency is desired.

lucapericlp commented 1 year ago

Apologies for the direct ping @radar (lmk whom else I might be able to ping in case) but I saw you recently merged in another PR - is this worth including or should we close?

radar commented 1 year ago

Sorry @lucapericlp, I must've missed this one back in May somehow. I try to review things within at least two weeks and give feedback then.

The change looks good now. Thanks for that!