search

ruby-i18n / i18n

Internationalization (i18n) library for Ruby
MIT License
976 stars 408 forks source link

A fix for failing CI against edge Rails #663

Closed amatsuda closed 1 year ago

amatsuda commented 1 year ago

Here's a fix for the edge Rails CI failure.

There's a test code directly accessing a cached instance variable inside Active Support MemoryStore object, but since Rails 7.1 changed its implementation to hold the @data ivar as a marshalled String, the test now fails on edge Rails.

This patch fixes the failure by properly calling publicly accessible API.

kbrock commented 1 year ago

Does this break jruby+rails5.2 - or is that unrelated? sorry. see ==> https://github.com/ruby-i18n/i18n/pull/664

radar commented 1 year ago

Thank you!!