search

ruby-i18n / i18n

Internationalization (i18n) library for Ruby
MIT License
976 stars 408 forks source link

undo strict racc dependency on this branch #687

Closed radar closed 6 months ago

radar commented 6 months ago

This causes people's builds to break.

See #685 for the discussion.

Yes, this means i18n will not install on Ruby 3.3 until you also install the Racc gem.

This will be addressed in an upcoming 2.x release for i18n.

radar commented 6 months ago

Confirming this branch fixes the issue by:

  1. Running a Docker container of ruby:3.0-alpine
  2. Cloning this repo
  3. Running rake install
  4. Having that install succeed

On master (pre merge), this would do:

Running `gem install /home/i18n/pkg/i18n-1.14.3.gem` failed with the following output:

Building native extensions. This could take a while...
ERROR:  Error installing /home/i18n/pkg/i18n-1.14.3.gem:
    ERROR: Failed to build gem native extension.

    current directory: /usr/local/bundle/gems/racc-1.7.3/ext/racc/cparse
/usr/local/bin/ruby -I /usr/local/lib/ruby/3.0.0 -r ./siteconf20240306-49-cwb37a.rb extconf.rb
creating Makefile

current directory: /usr/local/bundle/gems/racc-1.7.3/ext/racc/cparse
make DESTDIR\= clean
current directory: /usr/local/bundle/gems/racc-1.7.3/ext/racc/cparse
make DESTDIR\=
make failedNo such file or directory - make

Gem files will remain installed in /usr/local/bundle/gems/racc-1.7.3 for inspection.
Results logged to /usr/local/bundle/extensions/aarch64-linux-musl/3.0.0/racc-1.7.3/gem_make.out

Tasks: TOP => install
(See full trace by running task with --trace)