search

ruby-ldap / ruby-net-ldap

Pure Ruby LDAP library
https://rubygems.org/gems/net-ldap
Other
399 stars 253 forks source link

lib/net/ldap/connections.rb: use ** to pass a keyword parameter #350

Closed lucaskanashiro closed 4 years ago

lucaskanashiro commented 4 years ago

In Socket.tcp call is passed a keyword parameter as is and while I've been testing a library that relies on it I got the following warning:

net/ldap/connection.rb:709: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call

In ruby 2.7 is preferred to use ** to pass keyword arguments in method's call.

HarlemSquirrel commented 4 years ago

Thanks but we've got this taken care of now with #342