ruby-numo / numo-narray

Ruby/Numo::NArray - New NArray class library
http://ruby-numo.github.io/narray/
BSD 3-Clause "New" or "Revised" License
413 stars 41 forks source link

Release for Ruby 3.0 #180

Closed nerdinand closed 3 years ago

nerdinand commented 3 years ago

Hi there

Would it be possible to release this gem for Ruby 3.0 as well? It can't be installed there currently, because the gemspec forbids it. I built it locally for Ruby 3.0 and all the tests passed. This is all I changed:

--- a/numo-narray.gemspec
+++ b/numo-narray.gemspec
@@ -20,7 +20,7 @@ Gem::Specification.new do |spec|
   spec.summary       = %q{alpha release of Numo::NArray - New NArray class library in Ruby/Numo (NUmerical MOdule)}
   spec.homepage      = "https://github.com/ruby-numo/numo-narray"
   spec.license       = "BSD-3-Clause"
-  spec.required_ruby_version = '>= 2.2'
+  spec.required_ruby_version = '>= 3.0'

   spec.files         = `git ls-files Gemfile README.md Rakefile lib ext numo-narray.gemspec spec`.split($/)
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
kojix2 commented 3 years ago

On my local environment, gem install numo-narray works fine.

So I think it would be better to describe your environment in more detail.

nerdinand commented 3 years ago

Ah ok. I was on 0.9.1.8 still, not on 0.9.1.9. It works with the latest version. Thanks!