search

ruby-passkeys / devise-passkeys

Devise extension to use passkeys instead of passwords
MIT License
161 stars 12 forks source link

Remove unused `maximum_passkeys_per_user`; not the gem's concern #16

Closed tcannonfodder closed 1 year ago

tcannonfodder commented 1 year ago

The :maximum_passkeys_per_user attribute is legacy code from the early experiments in the gem (see: https://github.com/ruby-passkeys/devise-passkeys/blob/main/lib/devise/passkeys/passkey_issuer.rb#L38).

And validations/limits on the number of passkeys that can be created should be handled by the app itself. This keeps the gem focused, reduces our maintenance overhead, and gives implementors control over the exact behavior

johalloran01 commented 1 year ago

@tcannonfodder I can take this issue when I return home.

johalloran01 commented 1 year ago

Created a pull request for this issue: https://github.com/ruby-passkeys/devise-passkeys/pull/41