search

ruby-passkeys / devise-passkeys

Devise extension to use passkeys instead of passwords
MIT License
161 stars 12 forks source link

Add passkey keyword to `after_passkey_authentication` #26

Closed Vagab closed 1 year ago

Vagab commented 1 year ago

resolves #14

Vagab commented 1 year ago

@tcannonfodder let me know if I should add any tests

tcannonfodder commented 1 year ago

Yep, we definitely need tests for this 💪

Vagab commented 1 year ago

@tcannonfodder I see in a rails user model a comment saying we're checking that the validations were confirmed(here) but I wasn't able to find where do we actually check that 🥲 . Could you point me in the right direction? In the meanwhile, I've added tests for this callback into reauthentication integration test.

tcannonfodder commented 1 year ago

I...actually don't know if we're using those checks 😅. I need to dig into the tests. It's one of the places where devise gets gnarly because of how it's designed

tcannonfodder commented 1 year ago

Okay, it looks like that code is vestigial, from a previous implementation attempt. We should remove it in a subsequent PR

tcannonfodder commented 1 year ago

Waiting on CI to pass, but looks good! 💪

tcannonfodder commented 1 year ago

Ack, @Vagab can you rebase the latest main into this so that we can get CI to pass?