search

ruby-passkeys / devise-passkeys

Devise extension to use passkeys instead of passwords
MIT License
172 stars 13 forks source link

Refactor Controller concerns to not use `Warden::WebAuthn::StrategyHelpers` #29

Closed tcannonfodder closed 1 year ago

tcannonfodder commented 1 year ago

Note, this cannot be merged in until https://github.com/ruby-passkeys/warden-webauthn/issues/4 is merged and a new gem version is cut

This PR prevents the bleed-through caused by including all of Warden::WebAuthn::StrategyHelpers for a small number of methods.

This resolves #28

(@Vagab I can't add you as a reviewer directly, but would like your feedback on this one as well, since it would solve our discussion: https://github.com/ruby-passkeys/devise-passkeys/pull/25#issuecomment-1605239266)