Add tests and find other incorrect uses of `:user` instead of `resource_name` - Githubissues

ruby-passkeys / devise-passkeys

Devise extension to use passkeys instead of passwords

MIT License

161 stars 12 forks source link

Add tests and find other incorrect uses of `:user` instead of `resource_name` #40

Open tcannonfodder opened 1 year ago

tcannonfodder commented 1 year ago

In https://github.com/ruby-passkeys/devise-passkeys/pull/39/commits/5ef8c83ffe57b3719ab574a01c710ee3ba7dcfb1, we found code that used :user instead of resource_name. This would cause issues when implementing passkey controllers for non-user resources.

We need to:

Check the rest of the codebase for any additional uses of :user that should be resource_name
Write tests to prevent regressions, since there do not appear to be any