search

ruby-passkeys / devise-passkeys

Devise extension to use passkeys instead of passwords
MIT License
161 stars 12 forks source link

Load resource (when email is present) and return allowCredentials #47

Closed heliocola closed 1 year ago

heliocola commented 1 year ago

Context

Sign in for Android phones are not working Fixes: https://github.com/ruby-passkeys/devise-passkeys-template/issues/12

In this PR

Sign in new_challenge method load the resource, when email is present, and return allowCredentials so Android phones can find a passkey for the website and request the biometrics.

heliocola commented 1 year ago

@tcannonfodder : let me know if this proposed solution will work. If this is in the right direction, I will write some tests, and document the sessions controller concern.

FYI: I've found and fixed this first in another app I was working on and also tested (and replicated issue and solution) in the template app (https://github.com/ruby-passkeys/devise-passkeys-template/pull/16)

heliocola commented 1 year ago

This PR is being replaced by https://github.com/ruby-passkeys/warden-webauthn/issues/7