ruby-passkeys / devise-passkeys

Devise extension to use passkeys instead of passwords
MIT License
169 stars 13 forks source link

Test suite failing because of mismatched "Translation missing" messages #5

Closed johalloran01 closed 1 year ago

johalloran01 commented 1 year ago

Description

Attempted to run bundle exec appraisal rake test after installing the required gems using bundle exec appraisal install.

However, the test suite failed, with differences in the Translation missing error messages. For example:

Failure:
Devise::Passkeys::Controllers::TestReauthenticationControllerConcern#test_#reauthenticate:_user_not_verified [/devise-passkeys/test/devise/passkeys/controllers/test_reauthentication_controller_concern.rb:128]:
--- expected
+++ actual
@@ -1 +1,3 @@
-{"error"=>"translation missing: en.devise.failure.user.webauthn_user_verified_verification_error"}
+{"error"=>"Translation missing. Options considered were:
+- en.devise.failure.user.webauthn_user_verified_verification_error
+- en.devise.failure.webauthn_user_verified_verification_error"}

Environment

Screenshots/Files

Screenshot 2023-06-13 161554

Test output

test-run.log

tcannonfodder commented 1 year ago

It looks like this is a ripple effect of i18n version 1.14.0 https://github.com/rails/rails/issues/48377