search

ruby-passkeys / devise-passkeys

Devise extension to use passkeys instead of passwords
MIT License
161 stars 12 forks source link

Clarify the purpose of Passkey#label #57

Open asavageiv opened 2 months ago

asavageiv commented 2 months ago

Related to #56

asavageiv commented 2 months ago

Let’s keep the note that it’s required, and that you’ll want to scope it as well & ensure uniqueness. But adding this additional context is a great idea!

Thanks for the review! Isn't it already in the "required" section? I'm happy to add it back if you think the extra emphasis is needed.

Can you explain the "scope it" part? What would that mean for the example? If I have "admin" and "user" resource types do I want "Admin - test@example.com Firefox" or something? Why?