search

ruby-passkeys / devise-passkeys

Devise extension to use passkeys instead of passwords
MIT License
161 stars 12 forks source link

Rename `Devise::Passkeys::Controllers::Concerns::PasskeyReauthentication` => `Devise::Passkeys::Controllers::Concerns::Reauthentication` #7

Closed johalloran01 closed 1 year ago

johalloran01 commented 1 year ago

Find and replaced PasskeyReauthentication with Reauthentication, and test_passkey_reauthentication with test_reauthetntication. As well as renamed files.

heliocola commented 1 year ago

@tcannonfodder , @johalloran01 : how pick are you about adding these changes to CHANGELOG.md? ☺️

tcannonfodder commented 1 year ago

I’m not sure I follow? I did add them in a later commit, post-merging: https://github.com/ruby-passkeys/devise-passkeys/commit/de5011367923ea21cf67c534b123e01cd8868089 😄😅

heliocola commented 1 year ago

TY! Sorry about that! I've missed that! I was reviewing the PR and noticed no changes to CHANGELOG.md.

tcannonfodder commented 1 year ago

No worries! Just wanted to make sure I didn’t miss anything 😄