search

ruby-protobuf / protobuf

A pure ruby implementation of Google's Protocol Buffers
https://github.com/ruby-protobuf
MIT License
463 stars 101 forks source link

Messages fields should be able to be set with to_proto #309

Closed embark closed 8 years ago

embark commented 8 years ago

A prior commit (#302) introduced a bug so that you would get Failure/Error: fail TypeError, "Unacceptable value #{value} for field #{field.name} of type #{field.type_class}" when trying to set a message field with a class that defined a #to_proto method.

CC @zachmargolis @nerdrew @film42

zachmargolis commented 8 years ago

LGTM! thanks for fixing

nerdrew commented 8 years ago

+1

embark commented 8 years ago

@liveh2o @film42 Sorry for the ping, but does this look okay? Don't like to leave bugs around.

liveh2o commented 8 years ago

Don't hesitate to ping if you're not getting a response. We need to stay on top of this stuff.

embark commented 8 years ago

Comments addressed :)

liveh2o commented 8 years ago

:shipit:

liveh2o commented 8 years ago

It looks like we've got a few PRs stacking up. I'll check with @film42 and see we can cut a release tomorrow.