Allow to use rake task inside custom task many times

ruby-protobuf / protobuf

A pure ruby implementation of Google's Protocol Buffers

https://github.com/ruby-protobuf

MIT License

463 stars 101 forks source link

Allow to use rake task inside custom task many times #376

Closed mix86 closed 7 years ago

mix86 commented 7 years ago

This fix allows to reuse ::Rake::Task['protobuf:compile'].invoke in custom rake tasks. Because system call doesn't replace current process, but exec does.

film42 commented 7 years ago

Looks like we need to fix a few active support things. Code looks 👍 though!

film42 commented 7 years ago

~~Woo hoo! Released in v3.8.0! Thanks for the contribution!~~

Edit: See comment below.

stAndrei commented 7 years ago

Hello. Can you merge this pull request to 3.8 branch?

film42 commented 7 years ago

Oh my! For some reason I thought I merged into master. Thanks @stAndrei ! Let me cut a release with this in it.

film42 commented 7 years ago

Done! Merged into 3-8-stable and released in v3.8.1.