search

ruby-protobuf / protobuf

A pure ruby implementation of Google's Protocol Buffers
https://github.com/ruby-protobuf
MIT License
463 stars 101 forks source link

Update the compile task to work with protoc v3 #382

Closed liveh2o closed 6 years ago

liveh2o commented 6 years ago

The Protocol Buffers v3 compiler (protoc) now comes with a builtin Ruby plugin. This conflicts with our local custom Ruby plugin. In order to use it, the custom plugin must be passed to the compiler, and invoked via the custom output generator:

$ protoc --plugin=protoc-gen-ruby-protobuf=/path/to/bin/protoc-gen-ruby --ruby-protobuf_out=lib

Update the compile task to take this new pattern into account so that it works with both the v2 and v3 compilers.

// @film42 @brianstien

liveh2o commented 6 years ago

Resolves #341.

mvz commented 5 years ago

The wiki mentions the old method of compiling that no longer works. Unfortunately, I don't know enough yet to update it.