ruby-protobuf / protobuf

A pure ruby implementation of Google's Protocol Buffers
https://github.com/ruby-protobuf
MIT License
463 stars 101 forks source link

WIP: Adding tracing #392

Closed minond closed 5 years ago

minond commented 5 years ago

Adding service to service tracing using Opentracing. This is still a WIP, item left to do are the following:

abrandoned commented 5 years ago

@minond I think this is better as a gem that injects a middleware, any reason we don't take that approach?

minond commented 5 years ago

@abrandoned because of the extension added to the Request message.

minond commented 5 years ago

Closing this PR and getting another one up using the middleware feedback.