search

ruby-protobuf / protobuf

A pure ruby implementation of Google's Protocol Buffers
https://github.com/ruby-protobuf
MIT License
463 stars 101 forks source link

Request headers #393

Closed minond closed 5 years ago

minond commented 5 years ago

Adding general purpose headers to the request message. Something like this would allow us to pass the information required for tracing and open that field up for other uses as well.

@liveh2o, @abrandoned can I get your thoughts on this?

cc @film42

film42 commented 5 years ago

I'll cut a pre-release of this branch.

film42 commented 5 years ago

Released as 3.10.0.pre0. Probably would have been fine with a 3.9.1, but better safe than sorry.

minond commented 5 years ago

I'm not 100% sure yet but I think https://travis-ci.org/ruby-protobuf/protobuf/jobs/490739814 may be failing due to a race condition. I leaning towards that answer because I've had other jruby builds fail semi-randomly on this repo and the same build setup/config for my own fork used to create this PR is passing: https://travis-ci.org/minond/protobuf/jobs/490739793. If someone has any ideas as what what may be causing this let me know. Also, tests are passing locally with this configuration (my version of java is a little off but everything else is ok):

~/code/mx/protobuf-minond-testing > PATH="/usr/local/opt/protobuf@2.5/bin:$PATH" protoc --version
libprotoc 2.5.0
~/code/mx/protobuf-minond-testing > cat /usr/local/include/zmq.h | grep "define ZMQ_VERSION_"
#define ZMQ_VERSION_MAJOR 4
#define ZMQ_VERSION_MINOR 2
#define ZMQ_VERSION_PATCH 1
~/code/mx/protobuf-minond-testing > java -Xmx1g -version
java version "1.8.0_171"
Java(TM) SE Runtime Environment (build 1.8.0_171-b11)
Java HotSpot(TM) 64-Bit Server VM (build 25.171-b11, mixed mode)
~/code/mx/protobuf-minond-testing > javac -J-Xmx1g -version
javac 1.8.0_171
~/code/mx/protobuf-minond-testing > ruby --version
jruby 9.2.5.0 (2.5.0) 2018-12-06 6d5a228 Java HotSpot(TM) 64-Bit Server VM 25.171-b11 on 1.8.0_171-b11 +jit [darwin-x86_64]