search

ruby-protobuf / protobuf

A pure ruby implementation of Google's Protocol Buffers
https://github.com/ruby-protobuf
MIT License
463 stars 101 forks source link

Update TravisCI build #407

Closed mvz closed 2 years ago

mvz commented 5 years ago

Builds on newer protobuf versions while not allowing failures.

Follow-up for #406, which made the build for protobuf 3.0.0 green.

olleolleolle commented 4 years ago

@mvz Does it make sense to rebase this? Does it still work?

mvz commented 4 years ago

I don't think much has changed but I'll give it a shot.

mvz commented 4 years ago

It looks like there's a problem with pry and pry-byebug versions.

deivid-rodriguez commented 4 years ago

Yeah.

On ruby 2.3, pry-byebug gets resolved to a version older than the latest (3.7.0) because the latest does not support ruby 2.3. But pry gets resolved to 0.13 which is not supported by pry-byebug 3.7.0, only by the latest version.

Possible solutions:

mvz commented 4 years ago

It looks like the maintainers of this gem want to still target 2.3 (see #412), so I'll go with the first option.

olleolleolle commented 4 years ago

@mvz The rbx-2 needs to run in dist: trusty to even begin. If you're thinking of keeping it.

matrix:
  include:
    - rvm: rbx-2
      dist: trusty
mvz commented 4 years ago

I think I'll wait for #406 and perhaps #412 to be merged and then see again which parts of this pull request are still relevant.

mvz commented 2 years ago

Closing this since this project no longer uses TravisCI.