ruby-protobuf / protobuf

A pure ruby implementation of Google's Protocol Buffers
https://github.com/ruby-protobuf
MIT License
462 stars 101 forks source link

#to_json(:lower_camel_case) generates camel cased keys #410

Closed aslakhellesoy closed 4 years ago

aslakhellesoy commented 4 years ago

This is a fix for #408

I wasn't sure where to update the documentation - please let me know if you require more changes.

film42 commented 4 years ago

Thanks for this PR! Don't worry about the 1.9.3 failure. We should probably drop 1.9.3 support.

aslakhellesoy commented 4 years ago

Thanks for merging so quickly! I see you released 3.10.3, but CHANGES.md doesn't reflect it.

film42 commented 4 years ago

Thanks for the reminder! Totally spaced. I'll update CHANGES once I merge my PR that updates travis and gets CI passing again.

aslakhellesoy commented 4 years ago

I also believe you need to create a new 3-11-stable maintenance branch now eh? :-) Life as an open source contributor...