ruby-protobuf / protobuf

A pure ruby implementation of Google's Protocol Buffers
https://github.com/ruby-protobuf
MIT License
462 stars 101 forks source link

Require `active_support` before cherry-picking features #431

Closed byroot closed 9 months ago

byroot commented 10 months ago

It's part of the Active Support contract, the entry point must be loaded, otherwise requiring individual components may fail.

Fixes:

active_support/core_ext/time/conversions.rb:62:in `<class:Time>': undefined method `deprecator' for ActiveSupport:Module (NoMethodError)
    from gems/activesupport-7.1.1/lib/active_support/core_ext/time/conversions.rb:7:in `<top (required)>'
    from gems/activesupport-7.1.1/lib/active_support/core_ext/object/json.rb:14:in `require'
    from gems/activesupport-7.1.1/lib/active_support/core_ext/object/json.rb:14:in `<top (required)>'
    from gems/activesupport-7.1.1/lib/active_support/json/encoding.rb:3:in `require'
    from gems/activesupport-7.1.1/lib/active_support/json/encoding.rb:3:in `<top (required)>'
    from gems/activesupport-7.1.1/lib/active_support/json.rb:4:in `require'
    from gems/activesupport-7.1.1/lib/active_support/json.rb:4:in `<top (required)>'
    from gems/protobuf-cucumber-3.10.8/lib/protobuf.rb:10:in `require'
pason commented 9 months ago

Would be possible to merge this one in the near future?

JonRowe commented 9 months ago

This is causing failures for us in cucumber builds for rspec so would also love to see this merged 🙏

film42 commented 9 months ago

I like this.

film42 commented 9 months ago

Released as v3.10.8. Thanks for your contribution.