Closed abrisse closed 1 year ago
Interesting and unfortunate. I've tried to decrease the impact of log_* calls by leaving costly evaluation in the block, but there's no good way to avoid splat arguments. I've gone back and forth about commenting out logging, and it can be useful when trying to debug gnarly corner-cases. But, the log_debug calls probably make up the bulk and shouldn't be as necessary to get basic algorithm tracing as log_info, for example.
Hello @gkellogg,
While investigating some memory issues I discovered that the
log_debug
calls generate a lot of objects. Half of them were already commented so this PR comments all the others.I did a small benchmark with memory_profiler:
The 3 lines that stores a lot of objects:
This is partly because the RDF utils functions
logger_debug
/logger_common
use splat operators which is quite costly, so I think the PR provide the best ROI.