search

ruby-rdf / rdf-ldp

A suite of LDP software and middleware for RDF.rb & Rack
The Unlicense
13 stars 2 forks source link

Change call order in #destroy (L75-76) #62

Closed mjsuhonos closed 8 years ago

mjsuhonos commented 8 years ago

Destroy the LDP-NR contents after marking the Resource as destroyed, in case the interaction model logic requires access to the Resource before the StorageAdapter. Use case for this was triggering callbacks on a delegated object within NonRDFSource#destroy.

no-reply commented 8 years ago

:+1:

no-reply commented 8 years ago

Did we still want to get a regression test in for this? I was thinking of something where we force the super call to fail, and check that the file hasn't been deleted.

mjsuhonos commented 8 years ago

Right, I'd forgotten about a regression test. I'll whip something up.