allow haml 5.0 - Githubissues

ruby-rdf / rdf-rdfa

Ruby RDFa reader/writer for RDF.rb.

http://ruby-rdf.github.com/rdf-rdfa

The Unlicense

35 stars 11 forks source link

Closed jcoyne closed 7 years ago

jcoyne commented 7 years ago

This uses Erubi instead of Erubis. Erubis is deprecated in Rails 5.1.

gkellogg commented 7 years ago

Not sure how Erubis/Erubi plays into this; the gem uses Haml, and your patch seems to allow the use of haml 5 vs ~> 4.x.

For the Haml bit, seems to me we could just go to ~> 5.x unless preserving 4.x is necessary for earlier Rails versions.

jcoyne commented 7 years ago

@gkellogg Haml 5 adds support for Erubi. Haml 4 is Erubis only. I don't see any problem if you want to only allow 5.x.

abrisse commented 7 years ago

@gkellogg: I think we can close this issue