search

ruby-rdf / rdf-turtle

Turtle reader/writer for Ruby
http://rubygems.org/gems/rdf-turtle
The Unlicense
31 stars 9 forks source link

FreebaseReader doesn't read literals with PName datatype #3

Closed gkellogg closed 11 years ago

gkellogg commented 11 years ago

This was originally reported by @danharvey against rdf in https://github.com/ruby-rdf/rdf/issues/119.

The Freebase Reader does not correctly read a literal of the form "2013-05-09"^^xsd:date.

danharvey commented 11 years ago

Just tired this and it works fine thanks. I've made by own branch of 1.1 and added this commit to it which works fine too, and I think faster but I've not formally benchmarked it.

Would it be possible to apply this change to the 1.1 branch too so I can use that directly?

gkellogg commented 11 years ago

I'm not sure what your asking, I added my change to both master and 1.1 branches. Your change isn't necessary, and is inappropriate for N-Triples.

danharvey commented 11 years ago

Yes not my change sorry.

The fix you made for this, I don't think is in the 1.1 branch of rdf-turtle, just checked and the last commit was 17 days ago? https://github.com/ruby-rdf/rdf-turtle/commits/1.1

gkellogg commented 11 years ago

This commit: 34583c19a57c7eacba41de58e6e8987456cc67d2 was made on the 1.1 branch just after the same on master. When I look at the 1.1 branch on GitHub, it shows that as the last commit. Is it possible that you didn't merge these changes locally when you pulled?

danharvey commented 11 years ago

I'm comparing these two urls on github.

https://github.com/ruby-rdf/rdf-turtle/commits/master https://github.com/ruby-rdf/rdf-turtle/commits/1.1

Which I think are the two branches we're talking about? I only see the commit on master.

On 10 May 2013 15:32, Gregg Kellogg notifications@github.com wrote:

This commit: 34583c1https://github.com/ruby-rdf/rdf-turtle/commit/34583c19a57c7eacba41de58e6e8987456cc67d2was made on the 1.1 branch just after the same on master. When I look at the 1.1 branch on GitHub, it shows that as the last commit. Is it possible that you didn't merge these changes locally when you pulled?

— Reply to this email directly or view it on GitHubhttps://github.com/ruby-rdf/rdf-turtle/issues/3#issuecomment-17723481 .

gkellogg commented 11 years ago

Okay, that was odd, as it looks like the commit was pushed, but something didn't sync up. Should be there now.