search

ruby-rdf / rdf-vocab

Common RDF Vocabularies
The Unlicense
50 stars 29 forks source link

Geonames Vocabulary #22

Closed tpendragon closed 9 years ago

tpendragon commented 9 years ago

If this Vocabulary is too big to have Strict, I'd be happy to have a non-strict one.

Another note - when I ran rake gen_vocabs a LOT of the vocabularies had different syntax, should there be a PR for that?

gkellogg commented 9 years ago

What do you mean the vocabularies had different syntax, the new-style hash keys?

I'm not sure why the size of the vocabulary would determine strict or not. Lax is more important for informal vocabularies where terms are used, but not well defined.

tpendragon commented 9 years ago

@gkellogg When I run rake gen_vocabs some vocabs change like so:

     property :version,
       comment: %(The XML version declared in the XML declaration.).freeze,
-      domain: "http://www.w3.org/2011/content#ContentAsXML".freeze,
+      domain: "cnt:ContentAsXML".freeze,

As for the size of the vocabulary - that file's 5,000 lines. Is that okay? It means including this gem ends up requiring a significant amount of code.

gkellogg commented 9 years ago

That happens when the vocabulary isn't loaded, you can typically run again to get the compact version, but, of course, semantically they're the same. There may be some tweak to VocabularyLoader which could improve this. In such case, you can either fix up manually or try to re-run. Usually not an issue, except for file size, as you say.

If you want to tear into VocabularyLoader in RDF.rb, a PR would be gratefully accepted. Otherwise, feel free to update the PR with a manual fix.