search

ruby-rdf / sparql-client

SPARQL client for Ruby.
http://rubygems.org/gems/sparql-client
The Unlicense
112 stars 58 forks source link

Feature/fix graph option documentation #98

Closed white-gecko closed 2 years ago

white-gecko commented 2 years ago

Since cc9812c the interface to specify options has changed for the SPARQL::Client. I have reflected this change in the README and also have written a very stupid test. Unfortunately I don't know much about ruby test, so I was not able to write a test that checks that the default-graph-uri parameter is actually set.

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

gkellogg commented 2 years ago

Yes, the general change in Ruby since 2.0 has been to use **options instead of options = {}, and some respec matchers are now complaining when they are confused. I’ve recently found more tests to be updated, but hadn’t noticed the README issue.

coveralls commented 2 years ago

Coverage Status

Coverage remained the same at 95.182% when pulling 4c15993104034693ae306995b25b5fd36917e5b2 on white-gecko:feature/fixGraphOptionDocumentation into 3f52c37075e5e9ff0e6dab610910af1238cce1c8 on ruby-rdf:develop.