search

ruby-rdf / sparql

Ruby SPARQL library
http://rubygems.org/gems/sparql
The Unlicense
88 stars 14 forks source link

fixing missing `block` argument in sequence operator #50

Closed doriantaylor closed 4 months ago

doriantaylor commented 4 months ago

Found this crash scenario. Apparently I had fixed this months ago and not submitted?

coveralls commented 4 months ago

Coverage Status

coverage: 88.863%. remained the same when pulling ad4e51da905599aadc4099acf2b9d72a918834fb on doriantaylor:missing-block into 989964c1a83af177ddbae521a054f2be5291df0c on ruby-rdf:develop.

gkellogg commented 4 months ago

Great, thanks! Have you noticed other places where a block is expected but not defined?

gkellogg commented 4 months ago

My examination shows a number of operators that don't have a block argument, but these are all for Update, rather than Query, so this seems the only one that needs to be addressed.

doriantaylor commented 4 months ago

I didn't go looking for other missing blocks because I'm right in the middle of something but I can make a note to circle back and check later.