ruby-rice / rice

Ruby Interface for C++ Extensions
http://ruby-rice.github.io/
Other
370 stars 62 forks source link

Update Supporting Infrastructure #138

Closed cfis closed 3 years ago

cfis commented 3 years ago

This is a grab bag of 4 commits dealing with the supporting Rice infrastructure code. Let me know if you'd prefer them being split up.

The commits are:

jasonroelofs commented 3 years ago

Can we pull the M4 macro into its own PR? I'm hesitant to add project-level files like this to the repo as I expect they will get out-of-date quickly as I won't be using them.

cfis commented 3 years ago

Question - by "project level files" do you mean the Visual Studio solution? I can either not commit it or can make a separate commit.

I understand the worry about it getting out of date - that could definitely happen. In that case, its then a balance between something that isn't up to date but is 90% correct and thus is easy to fix up or having someone starting from scratch. However, since no one uses Ruby with MSVC (versus say Python where its all MSVC on Windows), I can certainly understand not including it.

Note this same issue would come up on MacOS with XCode. That case is a bit difference since I think it would be highly likely anyone working on wrapping a C++ library on MacOS would be using Xcode.

I suppose if this becomes a header only library at some point, this becomes moot outside of compiling/running tests.