search

ruby-rice / rice

Ruby Interface for C++ Extensions
http://ruby-rice.github.io/
Other
378 stars 63 forks source link

Support systems and installs who use `experimental/filesystem` includes #200

Closed jasonroelofs closed 10 months ago

jasonroelofs commented 10 months ago

Fixes #197

cc @thekendalmiller

jasonroelofs commented 10 months ago

Hmm, that's a lot of failures. Seems to be a change that only works on Mac right now.

thekendalmiller commented 10 months ago

afaict from messing with it this morning and also with your branch, on Ubuntu 22.04, I need to #include <version> or it fails like the github actions are failing.

But it seems <version> was added in c++20 so adding it doesn't help c++17. c++17 will still be broken.

The accepted answer on the stackoverflow is much more complicated. I was trying that but it's failing on c++17. I haven't figure out why yet

jasonroelofs commented 10 months ago

Closing for #201