search

ruby-rice / rice

Ruby Interface for C++ Extensions
http://ruby-rice.github.io/
Other
378 stars 63 forks source link

Version access #214

Closed uvlad7 closed 2 weeks ago

uvlad7 commented 2 weeks ago

version.rb doesn't follow standard Ruby directory hierarchy style for namespacing, it should be rice/version.rb (or rice-version.rb), currently it can be required by simply require "version", which is not OK.

For easy fix it's possible to just add require_relative 'version' into mkmf-rice.rb, so weird require "version" is not needed, but version is still added to the load path in that case and it might unexpectedly shadow other files.

cfis commented 2 weeks ago

I'm good with this change.

cfis commented 2 weeks ago

See https://github.com/ruby-rice/rice/pull/215