search

ruby-shoryuken / shoryuken

A super efficient Amazon SQS thread based message processor for Ruby. This project is in MAINTENANCE MODE. Reach me out on Slack link on the description if you want to become a new maintainer.
Other
2.06k stars 280 forks source link

✨ Add custom polling strategy configuration #693

Closed danielvdao closed 2 years ago

danielvdao commented 2 years ago

What

I was reading through an issue because I was curious (https://github.com/ruby-shoryuken/shoryuken/issues/675) and thought it could be fun to tackle. That said, if I am off track, please let me know.

This PR should add the ability to define custom polling strategies in .ymls using Object#const_get. To be honest, it's my first time using it, so if there are better ways -- happy to correct.

I also cleaned up a bit of code, but am happy to revert any refactoring changes if needed.

Gitmoji ref: https://gitmoji.dev/

danielvdao commented 2 years ago

@cjlarose let me know if this makes sense 🙇🏽‍♂️ , happy to close if not! Figured it would be a fun to try and contribute back 🙂

cjlarose commented 2 years ago

The approach, generally, looks great! The little refactors are welcome as well.

I'll take a deeper look later and do some local testing, but this looks solid. Thanks for the contribution!

n-ikhil commented 2 years ago

@cjlarose did you get chance to look at this ? as you said this looks very good !

cjlarose commented 2 years ago

This fell off my radar. I'll take another look!

danielvdao commented 2 years ago

Hey @cjlarose! Wanted to circle back in and check on this. Curious what's the status and would like to see if there's anything I should / can change for you 💚