delete_message_batch failed is returning nil rather than empty array …

ruby-shoryuken / shoryuken

A super efficient Amazon SQS thread based message processor for Ruby. This project is in MAINTENANCE MODE. Reach me out on Slack link on the description if you want to become a new maintainer.

Other

2.06k stars 280 forks source link

delete_message_batch failed is returning nil rather than empty array … #754

Closed JohnMaguir closed 12 months ago

JohnMaguir commented 1 year ago

…as before, default to empty array if nil returned.

I am seeing errors for Shoryuken::Queue#delete_messages

Processor failed: undefined method `any?' for nil:NilClass
ERROR: lib/shoryuken/queue.rb:26:in `delete_messages'

This simply defaults to an empty array if nil is returned for failed_messages.

Similar fix to #753

silasrnc commented 12 months ago

@JohnMaguir I had the same problem, updated to the latest version, and it worked.

phstc commented 12 months ago

@JohnMaguir thank you 🎉

phstc commented 12 months ago

Version 6.1.1 is out with your changes! Thank you again!