ruby / TryRuby

This 4th iteration of TryRuby is a website where you can learn the Ruby language.
https://try.ruby-lang.org
MIT License
226 stars 97 forks source link

Chinese version 网站的中文版本 #112

Closed ye-junzhe closed 2 years ago

ye-junzhe commented 2 years ago

Hello, I've been learning Ruby recently and love this site, plus I'm from China, so I'd like to add a Chinese version to this site and I'll try to finish it in a few weeks.

ye-junzhe commented 2 years ago

I have a problem with the language drop-down menu in the upper right corner of the page, I don't know which file to modify to add the "Chinese" option. I checked the PR #35 of other translators and found that their is different from the current version. Can someone tell me how to fix it?

ye-junzhe commented 2 years ago

Oh!! I think I found it in #107

Now must modify _navbar.html.erb to add options

hmdne commented 2 years ago

You closed #113 - I assume you want to do further work. Feel free to push a new PR when you are ready for a review :)

ye-junzhe commented 2 years ago

You closed #113 - I assume you want to do further work. Feel free to push a new PR when you are ready for a review :)

113 was an accident 🤣

114 check this out

hmdne commented 2 years ago

Great job :D Unfortunately I don't know Chinese so I can't proofread the strings (but I will ask if someone can), on code-side I found no apparent issues.

One tiny issue though, I believe you added a .DS_Store file by mistake. It contains some macOS metadata we don't need to store in the repo. It would be great if you could remove it.

ye-junzhe commented 2 years ago

Great job :D Unfortunately I don't know Chinese so I can't proofread the strings (but I will ask if someone can), on code-side I found no apparent issues.

One tiny issue though, I believe you added a .DS_Store file by mistake. It contains some macOS metadata we don't need to store in the repo. It would be great if you could remove it.

I think it is very important to listen to the opinions of others, can’t guarantee that the translation is 100% correct. 🔍 And .DS_Store is deleted

hmdne commented 2 years ago

The Chinese translation has been merged and is live now!

ye-junzhe commented 2 years ago

The Chinese translation has been merged and is live now!

Great work, thanks for your efforts. 🎉