search

ruby / TryRuby

This 4th iteration of TryRuby is a website where you can learn the Ruby language.
https://try.ruby-lang.org
MIT License
226 stars 97 forks source link

Chinese version（中文版本） #114

Closed ye-junzhe closed 2 years ago

ye-junzhe commented 2 years ago

Chinese version translation completed

hmdne commented 2 years ago

Ok, I'm going to sleep now. Thank you all for your hard work. One remaining request from my side: @McF4r can you note Bitfox (@bitfoxtop) and Heng Li (@iheng) either as coauthors or as reviewers? Tomorrow if there are no remaining suggestions I will do a final test if nothing breaks (maybe I will finally write some test suite...) and merge it.

ye-junzhe commented 2 years ago

Looks pretty good. I made few comments

Thanks man

ye-junzhe commented 2 years ago

Ok, I'm going to sleep now. Thank you all for your hard work. One remaining request from my side: @McF4r can you note Bitfox (@bitfoxtop) and Heng Li (@iheng) either as coauthors or as reviewers? Tomorrow if there are no remaining suggestions I will do a final test if nothing breaks (maybe I will finally write some test suite...) and merge it.

Sure, I will add them to the file.

hmdne commented 2 years ago

I changed a few things. Most importantly, the ISO language code for the Chinese language is ZH, not CN. Also a few corrections in the interactive part of this that were found by tests. I think we are ready to merge!