ruby / b.r-l.o

[Fork] Redmine for b.r-l.o
https://bugs.ruby-lang.org/
15 stars 15 forks source link

Fix email thread #112

Closed hanachin closed 4 years ago

hanachin commented 4 years ago

In Redmine 4.1, Message-ID and References contains user_id that passed to mailer methods.

Committed the patch. The new Message-ID formats are as follows:

Issue added:

Message-Id: redmine.issue-#{issue.id}.#{issue.created_on}.#{user_id}@example.net

Issue updated:

Message-Id: redmine.journal-#{jounal.id}.#{journal.created_on}.#{user_id}@example.net References: redmine.issue-#{issue.id}.#{issue.created_on}.#{user_id}@example.net https://www.redmine.org/issues/17096

To fix email thread, pass the same user (issue.author) to mailer methods.


Your contributions to Redmine are welcome!

Please open an issue on the official website instead of sending pull requests.

Since the development of Redmine is not conducted on GitHub but on the official website and core developers are not monitoring the GitHub repo, pull requests might not get reviewed.

For more detail about how to contribute, please see the wiki page Contribute on the official website.

hanachin commented 4 years ago

mame wrote in ruby-jp Slack #redmine channel:

雑に質問してしまうんですが、たぶん↓の影響で bugs.ruby-lang.org からの通知メールがスレッドにならなくなっているような気がしています。これって既知ですか? https://www.redmine.org/issues/17096 http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-core/97088 のメールのヘッダは Message-ID: redmine.issue-16615.20200207121817.12922@ruby-lang.org References: redmine.issue-16615.20200207121817.12922@ruby-lang.org になっていて、それに対するレスの http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-core/97089 のメールは Message-ID: redmine.journal-84195.20200207124837.3414@ruby-lang.org References: redmine.issue-16615.20200207121817.3414@ruby-lang.org になっています(blade だとメールヘッダみえないですが) 12922 と 3414 のところが違っていて、この番号はどうやらredmineに投稿した人の user id のようです https://bugs.ruby-lang.org/users/12922 https://bugs.ruby-lang.org/users/3414

hsbt commented 4 years ago

Thanks!