search

ruby / b.r-l.o

[Fork] Redmine for b.r-l.o
https://bugs.ruby-lang.org/
15 stars 15 forks source link

Fix notification emails for users #118

Closed jonathanhefner closed 3 years ago

jonathanhefner commented 3 years ago

This ensures that notification emails are sent to users after sending to the mailing lists.

Fixes #101.

This is an alternative approach to #115.

/cc @ahorek I've added you as a co-author since you've been exploring this.

jonathanhefner commented 3 years ago

It was difficult to run the tests locally (regardless of this change). If someone would like to test this, I would appreciate it. Otherwise, I will try again later.

hsbt commented 3 years ago

@jonathanhefner Thanks. I prefer to this change. Can you ready to review this?

jonathanhefner commented 3 years ago

@hsbt Yes, thank you.

deivid-rodriguez commented 3 years ago

I've been watching this PR for a while since I'm pretty excited about being able to get email notifications. Are there any plans to review it? Thanks!

By the way, I see that the bug tracker was upgraded or something and now it looks much more modern :heart_eyes:.

hsbt commented 3 years ago

Deployed at https://github.com/ruby/b.r-l.o/commit/5ae0c8c58b9ea9136ee66a766b801776e9e005f5

jonathanhefner commented 3 years ago

@hsbt Thank you for reviewing, and thank you for all of your contributions to the Ruby ecosystem! :bow: