search

ruby / csv

CSV Reading and Writing
https://ruby.github.io/csv/
BSD 2-Clause "Simplified" License
178 stars 113 forks source link

Fix an error for `CSV.open` #131

Closed koic closed 4 years ago

koic commented 4 years ago

Follow up to https://github.com/ruby/csv/pull/130/files#r434885191.

This PR fixes ArgumentError for CSV.open when processing invalid byte sequence in UTF-8.

kou commented 4 years ago

Thanks.

It seems that our benchmark doesn't show significant slow down:

Before: https://github.com/ruby/csv/runs/729090943?check_suite_focus=true After: https://github.com/ruby/csv/pull/131/checks?check_run_id=736633688

(I want to compare benchmark results automatically...)