search

ruby / csv

CSV Reading and Writing
https://ruby.github.io/csv/
BSD 2-Clause "Simplified" License
178 stars 114 forks source link

feat: add .idea on gitignore #240

Closed ericgpks closed 2 years ago

ericgpks commented 2 years ago

Change .gitignore file to ignore .idea and .idea/* files.

amatsuda commented 2 years ago

Please allow me to leave a general comment (I'm not a maintainer of this repo, but I just came across this PR).

Basically, a software project's .gitignore should not include any user-specific, system-specific, or some other software-specific files. If an editor or IDE that you use creates some garbage inside your working directory, that file should be ignored via your local .ignore mechanism, such as ~/.config/git/ignore file. Otherwise, we have to add *.swp and .idea and .vscode and *.tmproj and nbproject and .DS_Store and a lot more other 3rd party software specific entries to hundreds of millions of Git repositories.

Just for reference, here's how we treat this FAQ on a project that I'm involved in.

https://github.com/rails/rails/pull/7537 https://github.com/rails/rails/pull/24538 https://github.com/rails/rails/pull/42737 https://github.com/rails/rails/pull/541

ericgpks commented 2 years ago

Thank you for your comment. I agree with that opinion. So I close this pr.