:date_time converter fails to recognize "YYYY-MM-DD HH:MM"

[thyresias]

require "csv"
csv = '2022-06-14 18:48'
p CSV.parse(csv, converters: :date_time).first.first #=> "2022-06-14 18:48"
p DateTime.parse(csv) #=> #<DateTime: 2022-06-14T18:48:00+00:00 ((2459745j,67680s,0n),+0s,2299161j)>

There are two ways to solve this, I'm not sure which is the best one:

• make the seconds optional:

  DateTimeMatcher =
  / \A(?: (\w+,?\s+)?\w+\s+\d{1,2}\s+\d{1,2}:\d{1,2}:\d{1,2},?\s+\d{2,4} |
          \d{4}-\d{2}-\d{2}\s\d{2}:\d{2}(?::\d{2})? |
          # ISO-8601
          \d{4}-\d{2}-\d{2}
            (?:T\d{2}:\d{2}(?::\d{2}(?:\.\d+)?(?:[+-]\d{2}(?::\d{2})|Z)?)?)?
      )\z /x

• or allow "T" to be replaced by " ":

  DateTimeMatcher =
  / \A(?: (\w+,?\s+)?\w+\s+\d{1,2}\s+\d{1,2}:\d{1,2}:\d{1,2},?\s+\d{2,4} |
          \d{4}-\d{2}-\d{2}\s\d{2}:\d{2}:\d{2} |
          # ISO-8601
          \d{4}-\d{2}-\d{2}
            (?:[T ]\d{2}:\d{2}(?::\d{2}(?:\.\d+)?(?:[+-]\d{2}(?::\d{2})|Z)?)?)?
      )\z /x

[kou]

The former is the best because ISO 8601 requires T.

[kou]

Do you want to open a pull request for this?

[thyresias]

I can sure open a pull request, if you explain to me how this has to be done (or point me to a "how to"): I never did it before. ありがとう

[kou]

@ericgpks Could you support @thyresias ?

[ericgpks]

of course !

[ericgpks]

@thyresias Please fork this repository first of all, then create a branch to make a pull request. You make some changes on that branch and then push and open as a pull request. If you have any questions, you can ask anytime!!

[thyresias]

@ericgpks Thank you Eriko-san. I hope I did it right.