search

ruby / csv

CSV Reading and Writing
https://ruby.github.io/csv/
BSD 2-Clause "Simplified" License
181 stars 114 forks source link

Read StringIO with foreach #300

Closed MarcPer closed 3 months ago

MarcPer commented 6 months ago

Proposal

I'd like to propose being able to open a StringIO s with CSV.foreach(s), just as it's possible to open a file with CSV.foreach(path).

I can investigate and open a PR if this behavior is desired.

Current behavior

The documentation already says it should be possible to pass an IO object to foreach, but if an instance of StringIO is passed, we get:

no implicit conversion of StringIO into String (TypeError)
kou commented 6 months ago

If CSV.foeach(io) works, CSV.foreach(string_io) should work too.

MarcPer commented 6 months ago

Great, I'll open a PR with proposed changes in the next days.