search

ruby / date

A subclass of Object includes Comparable module for handling dates.
Other
70 stars 37 forks source link

Use endless method definition #92

Closed pusewicz closed 1 year ago

pusewicz commented 1 year ago

Given that we can now use the end-less method definitions for these short methods, let use it. It removes extra characters, which means less text to parse when reading.

jeremyevans commented 1 year ago

Date currently supports Ruby 2.6+. Endless methods weren't introduced until Ruby 3.0. So this would effectively drop support for Ruby 2.6 and 2.7. I don't think the tradeoff is worth it, but I'll leave the decision up to other maintainers. If you do want this considered, please update required_ruby_version in the gemspec.

pusewicz commented 1 year ago

Ah, in that case, this PR makes no sense. I'll close it. Thank you, @jeremyevans, for the extra context I was missing!