search

ruby / error_highlight

The gem enhances Exception#message by adding a short explanation where the exception is raised
MIT License
150 stars 23 forks source link

Tweak highlight range #17

Closed koic closed 1 year ago

koic commented 2 years ago

It seems to be clearer if the highlight range will be tweaked to the method name. Currently it contains dot.

Expected

1.time {}
  ^^^^
Did you mean?  times

Actual

1.time {}
 ^^^^^
Did you mean?  times
mame commented 2 years ago

I intentionally designed the current behavior to make it clear that it is a method call syntax, but I'm not sure which is better. Does anyone have an opinion?

mame commented 1 year ago

I would like to close this as I have not received any similar reports. I may reconsider if the underline turns out to be uncomfortable or obviously consufing to many people.