search

ruby / error_highlight

The gem enhances Exception#message by adding a short explanation where the exception is raised
MIT License
150 stars 23 forks source link

Use ruby/actions workflow for ruby versions #40

Closed m-nakamura145 closed 9 months ago

m-nakamura145 commented 9 months ago

Previously, Ruby versions in ruby.yml were specified using an array. However, this PR has been changed to use the ruby/actions workflow for version.

hsbt commented 9 months ago

@m-nakamura145 Thanks. Can you use min version to 3.0? HEAD version is already removed Ruby 3.0 from supported versions.

m-nakamura145 commented 9 months ago

@hsbt oh, sorry. I'd like to exclude Ruby 3.0 because error_highlight supports Ruby 3.1 and above. I thought I could exclude 3.0 by setting 3.1 in min_version input in ruby/actions. However, 3.0 cannot be excluded because cruby.json returns the following array. How should I set this up?

❯ curl https://cache.ruby-lang.org/pub/misc/ci_versions/cruby.json
["3.0","3.1","3.2","3.3","head"]

I think we can achieve this by improving this step.

hsbt commented 9 months ago

Ah, I see. It seems bug of ruby/actions. I will fix it next week.

m-nakamura145 commented 9 months ago

@hsbt Thanks for your help! I created https://github.com/ruby/actions/pull/56 👍

hsbt commented 9 months ago

@m-nakamura145 I appreciate your work. This change is working correctly.