search

ruby / fiddle

A libffi wrapper for Ruby.
BSD 2-Clause "Simplified" License
154 stars 37 forks source link

Fix PACK_MAP for unsigned types #110

Closed k0kubun closed 2 years ago

k0kubun commented 2 years ago

I think void* and unsigned types should be packed/unpacked as unsigned values.

k0kubun commented 1 year ago

FYI, I cherry-picked this to ruby/ruby https://github.com/ruby/ruby/commit/106744107b485a371ed788fe590c6ce778de16df as I needed to use this in ruby/ruby (MJIT).

I'd also like to cherry-pick https://github.com/ruby/fiddle/pull/111 if you're okay with it.

kou commented 1 year ago

I'm OK with it. You can merge the current master instead of cherry-picking some commits if you want.

k0kubun commented 1 year ago

got it, thank you!