search

ruby / gem_rbs_collection

A collection of RBS for gems.
MIT License
247 stars 101 forks source link

activerecord: Fix signatures of AR::Base.includes, .preload and .eager_load #480

Closed tk0miya closed 4 months ago

tk0miya commented 8 months ago

ActiveRecord::Base.includes, .preload and .eager_load can take association names in several forms; Strings, Symbols, Arrays of Strings, Hashes, and keywoard arguments.

Actually, the API document mentions such usages:

User.eager_load(:address, friends: [:address, :followers])

refs: https://api.rubyonrails.org/classes/ActiveRecord/QueryMethods.html#method-i-eager_load

pocke commented 5 months ago

Could you resolve the conflict?

BTW, Steepfile in gems/ directory has not been supported since #502. Please consider another way. I guess we can use Steep's expectation file feature (it is supported).

tk0miya commented 5 months ago

Rebased!