search

ruby / gem_rbs_collection

A collection of RBS for gems.
MIT License
247 stars 101 forks source link

set sidekiq redis direct dependency #493

Closed HoneyryderChuck closed 5 months ago

HoneyryderChuck commented 5 months ago

After rbs collection on a project with sidekiq, I'm getting " Cannot find type ::Redis" running steep. gems should be declaring their direct dependencies as well.

This is probably not the only "direct dependency" issue around, but it's enough to get the conversation started.

soutaro commented 5 months ago

gems should be declaring their direct dependencies as well.

Dependencies between gems are not managed by rbs-collection. It assumes Bundler takes care of them and load all of the required gems. manifest.yaml is for default gems and non-gem standard libraries. Because the dependency to default gems are rarely declared in Gemfile or .gemspec.

The correct fix might be adding redis-client gem type definition in this repository.

HoneyryderChuck commented 5 months ago

@soutaro you're saying that sidekiq switching from "redis" to "redis-client" is the reason? ok, that was unfortunate then :/