ruby / gem_rbs_collection

A collection of RBS for gems.
MIT License
246 stars 101 forks source link

Move generator under the gems/ directory #532

Closed pocke closed 3 months ago

pocke commented 3 months ago

This PR removes generators/ directory on the top level.

This change is necessary for the new reviewing workflow. If the generator is placed under the gems/GEM_NAME directory, the gem reviewer can modify the generator files. It improves maintainability of the generator.

github-actions[bot] commented 3 months ago

@pocke Thanks for your contribution!

Please follow the instructions below for each change. See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.


yard

You changed RBS files for an existing gem. You need to get approval from the reviewers of this gem.

@ksss, please review this pull request. If this change is acceptable, please make a review comment including APPROVE. After that, the PR author or the reviewers can merge this PR. Just comment /merge to merge this PR.


You changed non-gem files.

@pocke, please review and approve the changes.

github-actions[bot] commented 3 months ago

Thanks for your review, @pocke!

This PR still needs approval from the reviewers of the following gems.

github-actions[bot] commented 3 months ago

Thanks for your review, @ksss!

This PR still needs approval from the administrators. Please get approval from the reviewers.

pocke commented 3 months ago

/merge

github-actions[bot] commented 3 months ago

/merge command failed.

This PR is not approved yet by the reviewers. Please get approval from the reviewers. See the Actions tab for detail.

pocke commented 3 months ago

/merge