search

ruby / gem_rbs_collection

A collection of RBS for gems.
MIT License
246 stars 101 forks source link

Specify the gem version with `.0` suffix #547

Closed soutaro closed 2 months ago

soutaro commented 2 months ago

gem_rbs_collection usually assumes the directory name contains the major and minor version numbers. Generating the constraints with ~> #{version} results in ~> 7.0, which means testing activerecord/7.0/_test scripts with activerecord/7.1 definition.

Adding .0 generates ~> 7.0.0, which ensures running test in activerecord/7.0 with activerecord/7.1 definitions.

💡 You may want to do something smarter so that directory names with patch number works correctly.

github-actions[bot] commented 2 months ago

@soutaro Thanks for your contribution!

Please follow the instructions below for each change. See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.

You changed non-gem files.

@pocke, please review and approve the changes.

pocke commented 2 months ago

/merge

github-actions[bot] commented 2 months ago

Thanks for your review, @pocke!

@soutaro, @pocke This PR is ready to be merged. Just comment /merge to merge this PR.

github-actions[bot] commented 2 months ago

/merge command failed.

You do not have permission to merge this PR. PR author, reviewers, and administrators can merge this PR.